Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Toggle Light/Dark keyboard shortcut #10

Open
kupiqu opened this issue May 21, 2020 · 8 comments
Open

[REQUEST] Toggle Light/Dark keyboard shortcut #10

kupiqu opened this issue May 21, 2020 · 8 comments
Labels
Feature Request Requests for new features or feedback

Comments

@kupiqu
Copy link

kupiqu commented May 21, 2020

The title basically says everything... it would be great to switch between Light/Dark themes using a keyboard shortcut

@kupiqu kupiqu added the Feature Request Requests for new features or feedback label May 21, 2020
@baduhai
Copy link
Owner

baduhai commented May 21, 2020

This is an interesting one, making a keyboard shortcut to toggle would be simple enough, the problem is making it a global shortcut; i.e. available from wherever you are within Plasma. Not impossible but would require som research, will see what I can do.

@mirthestam
Copy link

KDE supports global shortcuts. You could implement this. Or, allow for command line instructions that one can configure manually.

@baduhai
Copy link
Owner

baduhai commented Jul 2, 2020

I've made some advancement on this front, hopefully will be on the next release.

@erwin
Copy link

erwin commented Oct 12, 2021

I think the preferable way would just be to add a few command line arguments to Koi

@jvyden
Copy link

jvyden commented Sep 16, 2022

Hello! Is there any news on this feature? It's not a priority since the current manual method of switching through the system tray icon's context menu is already fairly fast, but it would be nice to have.

I know Flameshot (a screenshotting utility) exposes some DBus calls that KDE Shortcuts can call. If for whatever reason the command line doesn't work out this is another method.

@baduhai
Copy link
Owner

baduhai commented Sep 16, 2022

I'll get around to it when I have some time. Thanks for posting how Flameshot does it, I remember research how to expose the shortcut to Plasma, but I didn't remember how it was done exactly.

Repository owner locked and limited conversation to collaborators Dec 21, 2023
Repository owner unlocked this conversation Dec 21, 2023
@MartinVonReichenberg MartinVonReichenberg added the Unfeasible This will not be worked on due to lack of skills, resources or interest label Jun 27, 2024
@shvedes
Copy link

shvedes commented Nov 9, 2024

I think that dumb, but still working temporary solution is add an ability to switch dark/light modes through command line, and then pass this to KDE shortcuts manually, so @erwin gave the good idea for the start

@acovaci
Copy link

acovaci commented Dec 20, 2024

So for the command line, an option would be to register a dbus method for this app like in this KDE tutorial. Thus, we could control it via qdbus which would get us part of the way, but it would also open up Koi to integration within the ecosystem. So I'd see it as an easy win-win.

I would say that would be an easy MVP, achieving most needs.

Then, if we want to expose it as a CLI option, we can simply wrap around qdbus for it.

Finally, if we want to go full integration, I think we can definitely use KGlobalAccel (docs) to register a global shortcut, potentially leaving it unset. And that would allow the user to go into settings and choose a shortcut for the "Toggle theme" action.

@MartinVonReichenberg MartinVonReichenberg removed the Unfeasible This will not be worked on due to lack of skills, resources or interest label Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Requests for new features or feedback
Projects
None yet
Development

No branches or pull requests

8 participants