Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate data on small-screen elements, a11y issues #55

Open
benaltair opened this issue Apr 28, 2021 · 1 comment
Open

Duplicate data on small-screen elements, a11y issues #55

benaltair opened this issue Apr 28, 2021 · 1 comment
Labels
accessibility Concerning accessibility.

Comments

@benaltair
Copy link
Member

image
Some have aria-hidden but so many don't. It's semantically confusing and not needed with modern CSS. The elements should only be included once, then transmuted with CSS as needed. This will be a long and progressive fix. See task list below.
@benaltair benaltair added the accessibility Concerning accessibility. label Apr 28, 2021
@benaltair
Copy link
Member Author

benaltair commented Apr 28, 2021 •
edited
Loading

article-details

  • DOI
  • Galleys
  • Title

benaltair added a commit that referenced this issue Apr 28, 2021
@benaltair
Removed dupe data for #55, improved #37
9c1b1b1
benaltair added a commit that referenced this issue Apr 28, 2021
@benaltair
Revert "Removed dupe data for #55, improved #37"
28df4c1 
This reverts commit 9c1b1b1.
benaltair added a commit that referenced this issue Apr 28, 2021
@benaltair
Copy desktop interaction to mobile
5dfa72d 
Not a great solution long-term. The way this was designed originally is
nasty. See #55 for more. Unmaintable and redundant.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility Concerning accessibility.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benaltair