Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result ordering by language is not working #117

Closed
martinheppner opened this issue Jun 14, 2024 · 2 comments
Closed

Result ordering by language is not working #117

martinheppner opened this issue Jun 14, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@martinheppner
Copy link
Contributor

martinheppner commented Jun 14, 2024

Opening https://www.zuugle.si/suche?city=ljubljana&map=true shows me at first german tours.

Image

When I execute the SQL below I see that 2.278 tours are reachable from Ljubljana (column text_lang = sl ), which should be the first results. This is why we did the UNION SQLs, to maintain the language order. Something might be broken (since the map)?

SELECT 
COUNT(*),
t.text_lang
FROM fahrplan AS f
INNER JOIN tour AS t
ON t.hashed_url=f.hashed_url
WHERE f.city_slug='ljubljana'
GROUP BY t.text_lang
@martinheppner martinheppner self-assigned this Jun 14, 2024
@martinheppner martinheppner added the bug Something isn't working label Jun 14, 2024
@diditrummer
Copy link

diditrummer commented Jun 14, 2024

We have checked the code. Following two remarks:

  1. When no search term is given the language of the tour seems to play no role in the ordering. Are you really sure that we had once this feature that without a search term the selected language determins which tours come first?
  2. Even when there is a search term the selected language is not "forced" to be on top. The search term needs to fit quite well to make a difference.

We want to talk to you about your expectations...

@martinheppner martinheppner assigned martinheppner and unassigned Falsal Jul 2, 2024
@martinheppner
Copy link
Contributor Author

Completely new search SQL - one for all usecases. Very fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants