Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"selection colors" incompatible with "dynamic cursor color" #167

Open
tsukishimashijima opened this issue Feb 25, 2025 · 0 comments
Open

Comments

@tsukishimashijima
Copy link

tsukishimashijima commented Feb 25, 2025

SELECTION_COLORS_PATCH apparently takes precedence over DYNAMIC_CURSOR_COLOR_PATCH, so the latter doesnt do its job

a (possibly dirty yet efficient) fix for this (in x.c) would be:

-	#if !DYNAMIC_CURSOR_COLOR_PATCH
+	#if (DYNAMIC_CURSOR_COLOR_PATCH && SELECTION_COLORS_PATCH) || !DYNAMIC_CURSOR_COLOR_PATCH
	/* remove the old cursor */
	if (selected(ox, oy))
		#if SELECTION_COLORS_PATCH
		og.mode |= ATTR_SELECTED;
		#else
		og.mode ^= ATTR_REVERSE;
		#endif // SELECTION_COLORS_PATCH
-	#endif // DYNAMIC_CURSOR_COLOR_PATCH
+	#endif // DYNAMIC_CURSOR_COLOR_PATCH / SELECTION_COLORS_PATCH
-		#if SELECTION_COLORS_PATCH
+		#if !DYNAMIC_CURSOR_COLOR_PATCH && SELECTION_COLORS_PATCH
		g.fg = defaultbg;
		g.bg = defaultcs;
		drawcol = dc.col[defaultcs];
		#else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant