Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to sync holders count #1082

Open
franzns opened this issue Oct 21, 2024 · 1 comment · May be fixed by #1125
Open

How to sync holders count #1082

franzns opened this issue Oct 21, 2024 · 1 comment · May be fixed by #1125

Comments

@franzns
Copy link
Collaborator

franzns commented Oct 21, 2024

HoldersCount cant be queried via rpc query but must come from subgraph. Its the only dynamic field we sync from there. It seems overkill to query each pool on the subgraph when we sync pools just to get the holders count as well.

In the old sync model, holders count was synced along with life time stats such as swapsCount or lifetimeVolume, I think we should sync holders count also in this context as HoldersCount doesnt seem like a very important field that needs to be updated in real time.

@gmbronco
Copy link
Collaborator

gmbronco commented Oct 21, 2024

holdersCount can be coming from the user balances which we already have in the DB. Balance syncing just needs to be made reliable #1083

@gmbronco gmbronco linked a pull request Oct 29, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants