Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to latest version of SE-2 frontend #43

Open
MattPereira opened this issue May 28, 2024 · 1 comment
Open

Upgrade to latest version of SE-2 frontend #43

MattPereira opened this issue May 28, 2024 · 1 comment

Comments

@MattPereira
Copy link
Member

MattPereira commented May 28, 2024

Overview

Since starting this build, SE-2 has released a major upgrade migrating from using the v1 versions of viem and wagmi to using the v2 versions instead.

Upgrading versions would allow for parsing of the event logs of the transaction receipts for swaps, joins, and exits. Viem v1 lacked support for this so I ended up setting up an event listener that points at the deployed contract which causes a lag between when the tx executes and when the frontend updates.

Since the migration from v1 to v2 versions is fairly intensive and involves many changes to a lot of the custom hooks and components, the best strategy may be to transplant the content of the current scaff bal frontend into the latest version of a fresh SE-2 frontend.

The backend packages/foundry folder will remain unchanged

@MattPereira MattPereira added the priority: low Not as important. Do these issues last label Jun 16, 2024
@MattPereira MattPereira removed the priority: low Not as important. Do these issues last label Aug 22, 2024
@MattPereira
Copy link
Member Author

MattPereira commented Sep 2, 2024

Looks like this upgrade will be needed in order to take advantage of the SDK's buildCallWithPermit2 because it relies on viem v2 Client which is different from viem v1 Client

EDIT: I misunderstood the SDK. Permit2Helper is only for internal testing. buildCallWithPermit2 is now being used for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant