Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sensorId in MagicMirror #2

Open
balassy opened this issue Jun 18, 2019 · 2 comments
Open

Support sensorId in MagicMirror #2

balassy opened this issue Jun 18, 2019 · 2 comments

Comments

@balassy
Copy link
Owner

balassy commented Jun 18, 2019

No description provided.

@coderpussy
Copy link

coderpussy commented Feb 3, 2021 •
edited
Loading

Hi György,
first of all i love your sketch for the weather station.

Is this issue still open? As far as i can see is that your MMM-RemoteTemperature module is providing this and an additional parameter in the magicmirror-client.cpp can be added. Or is there any problematic that i'm not understanding. ;-)

@balassy
Copy link
Owner Author

balassy commented Feb 7, 2021

Hello Maja,

You're right, the MMM-RemoteTemperature module already supports this parameter, but it is missing from the device code. Yes, it should be added to the magicmirror-client.cpp file, preferable in an easily configurable way.

Thanks for your feedback!
György

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balassy @coderpussy