-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default values for options mentioned in config/global.js file? #7298
Comments
@chauhankiran Thanks for posting! We'll take a look as soon as possible. In the mean time, there are a few ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
Something like this in Instead of throwing error, set // `sails.config.globals._` must be false or an object.
// (it's probably a function with lots of extra properties, but to future-proof, we'll allow any type of object)
if (sails.config.globals._ !== false) {
if (!_.isObject(sails.config.globals._)) {
// throw flaverr(
// { name: "userError", code: "E_BAD_GLOBAL_CONFIG" },
// new Error(
// "As of Sails v1, `sails.config.globals._` must be either `false` or a locally-installed version of Lodash (typically `require('lodash')`). For more info, see http://sailsjs.com/config/globals"
// )
// );
global["_"] = false;
}
global["_"] = sails.config.globals._;
}
// `sails.config.globals.async` must be false or an object.
// (it's probably a plain object aka dictionary, but to future-proof, we'll allow any type of object)
if (sails.config.globals.async !== false) {
if (!_.isObject(sails.config.globals.async)) {
// throw flaverr(
// { name: "userError", code: "E_BAD_GLOBAL_CONFIG" },
// new Error(
// "As of Sails v1, `sails.config.globals.async` must be either `false` or a locally-installed version of `async` (typically `require('async')`) For more info, see http://sailsjs.com/config/globals"
// )
// );
global["async"] = false;
}
global["async"] = sails.config.globals.async;
}
// `sails.config.globals.sails` must be a boolean
if (sails.config.globals.sails !== false) {
if (sails.config.globals.sails !== true) {
// throw flaverr(
// { name: "userError", code: "E_BAD_GLOBAL_CONFIG" },
// new Error(
// "As of Sails v1, `sails.config.globals.sails` must be either `true` or `false` (Tip: you may need to uncomment the `sails` setting in your `config/globals.js` file). For more info, see http://sailsjs.com/config/globals"
// )
// );
global["sails"] = true;
}
global["sails"] = sails;
}
// `sails.config.globals.models` must be a boolean.
// `orm` hook takes care of actually globalizing models and adapters (if enabled)
if (
sails.config.globals.models !== false &&
sails.config.globals.models !== true
) {
// throw flaverr(
// { name: "userError", code: "E_BAD_GLOBAL_CONFIG" },
// new Error(
// "As of Sails v1, `sails.config.globals.models` must be either `true` or `false` (you may need to uncomment the `models` setting in your `config/globals.js` file). For more info, see http://sailsjs.com/config/globals"
// )
// );
sails.config.globals.models = true;
} TODO: Also something for |
Hey @chauhankiran nice tinkering, so ideally you'd want to scaffold a new Sails project with That said, if you'd like a course to sort of help you understand how to get started with Sails, you can check out the Getting Started with Sails course on Sailscasts(I'll gift you the course for free, just send over your email) Also you can join the Sailscasts community to ask your Sails questions. |
Hey @chauhankiran would you say this issue has been resolved yet or do you need further help 😃? |
Node version: 18.17.9
Sails version (sails): 1.5.7
ORM hook version (sails-hook-orm): 4.0.2
Sockets hook version (sails-hook-sockets): N/A
Organics hook version (sails-hook-organics): N/A
Grunt hook version (sails-hook-grunt): N/A
Uploads hook version (sails-hook-uploads): N/A
DB adapter & version (e.g. [email protected]): Default that comes with
sails-hook-orm
Skipper adapter & version (e.g. [email protected]):
For the purpose of learning, creating a Sails application from the scratch without
sails new
command. While doing so, I created amodels
folder and then createUser.js
file in it. In order to run this line in Controller,I need to create a file with name
globals.js
inconfig
folder to markmodels
optiontrue
. Not just that but also need to mark_
tofalse
,async
tofalse
, andsails
totrue
. If the options are missing with the values, it throws error like this.As
_
(or other above mentioned options) can have eitherfalse
or specific value, Is it possible to have the default value on Sails side e.g._
is set to by defaultfalse
by Sails and then using thisconfig/globals.js
file, one can override the option? Even further is it possible to work directly withUser
as model without creatingglobals.js
file? I'm fine if I need to createconfig/models.js
file as it logically make sense.The text was updated successfully, but these errors were encountered: