Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor deletes no longer defined service before finishing update #2095

Open
majorz opened this issue Jan 23, 2023 · 1 comment · Fixed by #2230
Open

Supervisor deletes no longer defined service before finishing update #2095

majorz opened this issue Jan 23, 2023 · 1 comment · Fixed by #2230
Labels

Comments

@majorz
Copy link

majorz commented Jan 23, 2023

When the download-then-kill update strategy is being used, if the new release removes a service, that service is killed and deleted early in the process (before the download of the new release is completed). If the update fails the device is left with a missing service.

@jellyfish-bot
Copy link

[majorz] This has attached https://jel.ly.fish/cd50ddb0-3e0a-4fa7-8991-d61529048cb4

@pipex pipex added the type/bug label Jan 23, 2023
cywang117 added a commit that referenced this issue Jan 4, 2024
This pertains to a release update which removes a service in current state
and adds a new service in target state, which the Supervisor previously
didn't follow update strategies for starting / killing / fetching images for.

Change-type: patch
Closes: #2095
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Jan 14, 2024
This pertains to a release update which removes a service in current state
and adds a new service in target state, which the Supervisor previously
didn't follow update strategies for starting / killing / fetching images for.

Change-type: patch
Closes: #2095
Signed-off-by: Christina Ying Wang <[email protected]>
cywang117 added a commit that referenced this issue Jan 29, 2024
Fixes behavior for release updates which removes a service in current state
and adds a new service in target state.

Change-type: patch
Closes: #2095
Signed-off-by: Christina Ying Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants