Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service worker #419

Closed
joeframbach opened this issue Jan 6, 2022 · 1 comment
Closed

Remove service worker #419

joeframbach opened this issue Jan 6, 2022 · 1 comment

Comments

@joeframbach
Copy link

Service worker attempts to load the service-worker runner from Google. The Thing has no internet access, so this will fail. There is no need for a service worker in this application. The user's device connects directly to the Thing, there is no need to precache static assets in the service worker. The user can just get it from the Thing directly.

@joeframbach
Copy link
Author

The service worker file is generated by create-react-app but not used. Closing this ticket. An upgrade to create-react-app will remove the service worker file, since the behavior changed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant