Implement file type defnition mapping #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Tatskaari
commented
May 5, 2021
| private static Map<String, LSPExtensionManager> extToExtManager = new ConcurrentHashMap<>(); | ||
| private static final Map<String, Set<LanguageServerWrapper>> projectToLanguageWrappers = new ConcurrentHashMap<>(); | ||
| private static final Map<Pair<String, String>, LanguageServerDefinition> extToServerDefinition = new ConcurrentHashMap<>(); | ||
| private static final Map<Pair<Class<? extends FileType>, String>, LanguageServerDefinition> fileTypeToServerDefinition = new ConcurrentHashMap<>(); |
There was a problem hiding this comment.
I'm a bit new to this but it might be a safe assumption to assume that all file types are singletons and have this be
private static final Map<Pair<FileType, String>, LanguageServerDefinition> fileTypeToServerDefinition = new ConcurrentHashMap<>();
| @@ -67,7 +66,7 @@ public Object collectInformation(@NotNull PsiFile file, @NotNull Editor editor, | |||
| VirtualFile virtualFile = file.getVirtualFile(); | |||
|
|
|||
| // If the file is not supported, we skips the annotation by returning null. | |||
| if (!FileUtils.isFileSupported(virtualFile) || !IntellijLanguageClient.isExtensionSupported(virtualFile)) { | |||
| if (!FileUtils.isFileSupported(virtualFile) || !FileUtils.isFileSupported(virtualFile)) { | |||
| import org.eclipse.lsp4j.VersionedTextDocumentIdentifier; | ||
| import org.wso2.lsp4intellij.client.languageserver.requestmanager.RequestManager; | ||
| import com.intellij.openapi.vfs.VirtualFile; | ||
| import org.eclipse.lsp4j.*; |
There was a problem hiding this comment.
Lets avoid wildcard imports.
| import java.util.HashSet; | ||
| import java.util.Map; | ||
| import java.util.Set; | ||
| import java.util.*; |
There was a problem hiding this comment.
Lets avoid wildcard imports.
|
I'm unlikely to come back to this. I've instead taken to writing a language plugin based off the Python language for my use case. Feel free to fix this up, or close this PR as you see fit. |
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #252
Goals
Lots of files don't have extension:
Makefile,Dockerfile, and in my case:BUILDfiles. Mapping a definition to a filetype also seems to fit into the Intellij framework better.Approach
Added a new map to IntellijLanguageClient and added new API methods to register definitions against a filetype.
Release note
LanguageServerDefinitions can now be registered against file types with IntellijLanguageClient#addServerDefinition