Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove timeout minimum for Snackbar & Toast components? #182

Open
nlocascio opened this issue Mar 4, 2024 · 1 comment
Open

Remove timeout minimum for Snackbar & Toast components? #182

nlocascio opened this issue Mar 4, 2024 · 1 comment

Comments

@nlocascio
Copy link

nlocascio commented Mar 4, 2024

Would you be open to removing the minimum timeout settings on the Snackbar & Toast components?

We have a use case for displaying a notification that persists until the user manually dismisses it (via an action on the Snackbar/Toast itself, or via some other action within the UI), so we'd like to be able to pass 0 or null as the timeout and get a component that doesn't automatically disappear. We have seen this option available on

I would be happy to open a PR with this change if it sounds OK to you.

Thank you!

@nlocascio nlocascio changed the title Remove timeout for Snackbar & Toast components? Remove timeout minimum for Snackbar & Toast components? Mar 4, 2024
@elf-mouse
Copy link
Member

Hi @nlocascio , the latest/legacy version of <ui-snackbar> has support for this feature (timeoutMs = -1).

And toast has no action buttons by design definition, so there is no need to disable timeoutMs.

Thank you very much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants