From 088257d626d4be3156a1cf63023ae0eb6364431e Mon Sep 17 00:00:00 2001 From: Robert Bamler Date: Wed, 23 Oct 2024 12:27:07 +0200 Subject: [PATCH] CI: explicitly build for old Apple chips Github's CI infrastructure seems to have updated to new apple chips. Thus, by default, maturin compiles packages for new apple chips when run on macos. This commit makes sure we still also run cross compilation for old (intel) Apple hardware. --- .github/workflows/release.yaml | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 24c118a..52e4a36 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -353,21 +353,22 @@ jobs: manylinux: 2014 args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13 - - name: Build wheels (macos) - if: matrix.os == 'macos-latest' + - name: Build wheels (windows) + if: matrix.os == 'windows-latest' uses: messense/maturin-action@v1 with: command: build - args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13 + args: --release --strip --features pybindings -i C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-8.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-9.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-10.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-11.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-12.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-13.outputs.python-version }}\x64\python3.exe - - name: Build wheels (windows) - if: matrix.os == 'windows-latest' + - name: Build wheels for old Apple chips (macos) + if: matrix.os == 'macos-latest' uses: messense/maturin-action@v1 with: + target: x86_64-apple-darwin command: build - args: --release --strip --features pybindings -i C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-8.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-9.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-10.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-11.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-12.outputs.python-version }}\x64\python3.exe C:\hostedtoolcache\windows\Python\${{ steps.setup-python-3-13.outputs.python-version }}\x64\python3.exe + args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13 - - name: Cross-build wheels for Apple Silicon + - name: Cross-build wheels for new Apple chips (macos) if: matrix.os == 'macos-latest' uses: messense/maturin-action@v1 with: @@ -375,7 +376,7 @@ jobs: command: build args: --release --strip --features pybindings -i python3.8 python3.9 python3.10 python3.11 python3.12 python3.13 - - name: Build universal2 wheels + - name: Build universal2 wheels (macos) if: matrix.os == 'macos-latest' uses: messense/maturin-action@v1 with: