Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IFX edit parameter not recalled correctly on FX type change after pattern change. #17

Open
BKLronin opened this issue Nov 25, 2021 · 10 comments
Labels
bug Something isn't working

Comments

@BKLronin
Copy link

BKLronin commented Nov 25, 2021

When using the lag effect on asnare for groove purposes, it seems the it gets quantized later as the set value. The value itself is correctly safed and after setting to orig value the timing is correct again.

@bangcorrupt
Copy link
Owner

Can confirm, will investigate.

@bangcorrupt bangcorrupt added the bug Something isn't working label Nov 25, 2021
@bangcorrupt
Copy link
Owner

bangcorrupt commented Nov 26, 2021

This may have to wait until I get a debugger attached to the DSP. It looks like it's returning to the default value in the effect unit definition. Will require stepping through to see how the DSP code handles the data sent from the CPU.

@bangcorrupt bangcorrupt changed the title Late IFX Value "quantized" after pattern reload Lag IFX Value "quantized" after pattern reload Nov 26, 2021
@BKLronin
Copy link
Author

Ok cool, I´m just making some beats currently to test all functions.

@BKLronin
Copy link
Author

Is it just me or is the recording quantization much finer? I can remember quantizing almost all of my grooves out in the original fw. (not IFX related)

@bangcorrupt
Copy link
Owner

Shouldn't be any difference. If you're not using any groove template or swing, everything should be grid locked.

@BKLronin
Copy link
Author

Ok, just placebo or my timing got more conventional recently :D

The lag ifx is pretty nice for that. LIttle more natural to dial in other than the grooves.

@bangcorrupt
Copy link
Owner

It looks like all IFX are being reset to Edit value of 64. Probably missed updating a pointer somewhere.

@BKLronin
Copy link
Author

At least for lag and overdrive the orig value when loading the pattern is correctly safed but I have to manually move it to this position where it shows "orig". Thats not the case for one of the filterdrivers they have the 64 orig value as you have said.

@bangcorrupt
Copy link
Owner

bangcorrupt commented Nov 27, 2021

a939c6a appears to recall IFX Edit values correctly

Not entirely fixed.

@bangcorrupt bangcorrupt changed the title Lag IFX Value "quantized" after pattern reload IFX edit parameter not recalled correctly on FX type change after pattern change. Jan 15, 2022
@bangcorrupt bangcorrupt reopened this Jan 15, 2022
@bangcorrupt
Copy link
Owner

bangcorrupt commented Jan 15, 2022

  1. Set IFX type to 'LP Drive'
  2. Set IFX Edit to minimum
  3. Save pattern
  4. Increment pattern
  5. Decrement pattern
  6. IFX Edit value is recalled correctly
  7. Increment IFX Type
  8. Decrement IFX Type
  9. IFX Edit has returned to default 64 <-- Error
  10. Set IFX Edit to minimum
  11. Increment IFX Type
  12. Decrement IFX Type
  13. IFX Edit value is recalled correctly

Find missed index and set to IFX max count.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants