Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify e2sSample.all file format to include key/velocity mapping. #27

Open
bangcorrupt opened this issue Nov 28, 2021 · 10 comments
Open
Labels
enhancement New feature or request

Comments

@bangcorrupt
Copy link
Owner

bangcorrupt commented Nov 28, 2021

Sound engine handles key and velocity mapping of samples but it is not used (synth uses key mapping for some instruments). File format of e2sSample.all does not include data for key and velocity mapping.

@bangcorrupt bangcorrupt added the enhancement New feature or request label Nov 28, 2021
@gradientledge
Copy link

i have 2 programs to edit the .all files but are full of bugs, and every all file pops an error when i try to load it any suggestions? i pretty much just put the blank in there and edited it from the device.

@bangcorrupt
Copy link
Owner Author

any suggestions?

Answered in #29.

@BKLronin
Copy link

I´ve read somewhere that the factory bank of the Sampler uses at least velocity for theire samples.

@bangcorrupt
Copy link
Owner Author

Looking at the data in the flash, the sampler doesn't use key or velocity mapping for any samples. The synth uses key mapping for the keys, bass guitar and I think horns. When a note is triggered, the key and velocity information is read from RAM, but for most samples there is only a single key group and velocity layer. The existing data format allows for 4 velocity layers and (maybe) 128 key groups, but there is not a section for this information in the e2sSample.all file format.

@BKLronin
Copy link

OK, so there is no possibility to save the layers or zones? Maybe they ditched during development for some reason, like eating up voices as one of the layer is still playing when triggerin the other. That would cause like 4 voices per part when all velocity zones are used. 16 for a small drumset is a lot :D

@BKLronin
Copy link

What about embedding multiple velocitys, from a bass guitar for example, into a loop and map the individual slices to the velocitys? That would trigger just one voice too. Maybe use the "tune" variable to define the slice position for example.

Might be really difficult and I´m not sure if its worth it.

@bangcorrupt
Copy link
Owner Author

I think it's all already handled, just not used. I'll work on this once I finish grooves/FX import/export.

@BKLronin
Copy link

Ah ok, I thought its implemented but cannot be used as the "all" file cant save it in any way.

@bangcorrupt
Copy link
Owner Author

bangcorrupt commented Nov 29, 2021

I think I can add to the end of each sample block, or put a new section at the end of the file. Editors will need updating, will definitely be a long time.

@BKLronin
Copy link

Hijacking the tune parameter might be easier because the editors can be used unchanged and maybe fewer internal problems?

Might be something for later anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants