Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove openBao workaround when its been released #112

Open
csatib02 opened this issue Mar 25, 2024 · 0 comments
Open

Remove openBao workaround when its been released #112

csatib02 opened this issue Mar 25, 2024 · 0 comments
Assignees
@csatib02
Labels
good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.

Comments

@csatib02
Copy link
Member

There is a workaround applied in provider/bao/config.go and in env_store.go, remove those when, openBao utilizes BAO_ADDR, instead of VAULT_ADDR
@csatib02 csatib02 self-assigned this Mar 25, 2024
@csatib02 csatib02 mentioned this issue Mar 25, 2024
Merged
@csatib02 csatib02 added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/provider/bao labels Apr 30, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jul 7, 2024
@csatib02 csatib02 added lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jul 7, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jul 7, 2024
@csatib02 csatib02 added the good first issue Good for newcomers label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csatib02 csatib02

Labels
good first issue Good for newcomers kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/keep Denotes an issue or PR that should be preserved from going stale.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csatib02