Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version number #1

Open
javiercr opened this issue Apr 29, 2017 · 0 comments
Open

Version number #1

javiercr opened this issue Apr 29, 2017 · 0 comments

Comments

@javiercr
Copy link
Member

First of all thank you for contributing with a new adapter!

Just one thing I've noticed is that the version number pushed yo rubygems is 1.0.0. In other adapters we're using the 2.x.x as a way to indicate that is an adapter only compatible with bankscrap v2, as the v1 was a quite different implementation.

Do you think we should do the same with all adapters, including this, or it doesn't make sense?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@javiercr