From ab40ae0989768507ee67df29972777d6d6de7c0a Mon Sep 17 00:00:00 2001 From: Jose Martins Date: Fri, 13 Oct 2023 13:18:34 +0100 Subject: [PATCH] fix(docker): set ROOT_DIR var uppercase User-defined upper case variables are suppose to signal a user input option. That is, the use can decide what directory to run the container on. Signed-off-by: Jose Martins --- README.md | 2 +- docker/Makefile | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 1bc284b..c3fa7de 100644 --- a/README.md +++ b/README.md @@ -133,7 +133,7 @@ Finally, if you prefer, you can build the container image locally by running: make -C ci/docker build ``` -In the case you want to use the locally built imaghe, or just not want to fetch +In the case you want to use the locally built image, or just not want to fetch the latest available docker image, when invoking the Makefile you should tell it you want to use the local image and not fetch it automatically. This is also useful when you don't have a network connection or just want to skip that step diff --git a/docker/Makefile b/docker/Makefile index 378c535..3f0f560 100644 --- a/docker/Makefile +++ b/docker/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: Apache-2.0 # Copyright (c) Bao Project and Contributors. All rights reserved -root_dir?=$(realpath ../..) +ROOT_DIR?=$(realpath ../..) DOCKER?=$(shell which docker) docker_repo:=baoproject/bao