From 462827871488006e1fc209b822feb26a19621648 Mon Sep 17 00:00:00 2001
From: "Roscoe A. Bartlett" <rabartl@sandia.gov>
Date: Thu, 5 Oct 2023 17:55:54 -0600
Subject: [PATCH] Revert "Only assert defined vars conditionally"

This reverts commit 05d442940db0e02fd45a8ee0af6d8d3e549a6035.

I am going to implement what I believe is a better, more robust solution in a
later commit (after adding a failing test to cover the case that this commit
addresses).
---
 tribits/core/package_arch/TribitsPackageMacros.cmake | 12 +++---------
 1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/tribits/core/package_arch/TribitsPackageMacros.cmake b/tribits/core/package_arch/TribitsPackageMacros.cmake
index 74c54a310..d7931c406 100644
--- a/tribits/core/package_arch/TribitsPackageMacros.cmake
+++ b/tribits/core/package_arch/TribitsPackageMacros.cmake
@@ -440,19 +440,13 @@ macro(tribits_disable_optional_dependency  upstreamPackageName  reasonStr)
       "  Instead, please call this from the package's base CMakeLists.txt file"
       " '${${PACKAGE_NAME}_SOURCE_DIR}/CMakeLists.txt'" )
   endif()
-  # Get the variable names that are going to be set
+  # Get the variable names that are going to be set assert they exist already
   set(packageEnableVarName ${PACKAGE_NAME}_ENABLE_${upstreamPackageName})
+  assert_defined(${packageEnableVarName})
   string(TOUPPER  ${upstreamPackageName}  upstreamPackageName_UC)
   set(havePackageUpstreamPackageMacroVarName
     HAVE_${PACKAGE_NAME_UC}_${upstreamPackageName_UC})
-  # Assert that the vars already exist (to make sure the package and dependency exist)
-  if (${PROJECT_NAME}_ASSERT_DEFINED_DEPENDENCIES  IN_LIST
-      ${PROJECT_NAME}_ASSERT_DEFINED_DEPENDENCIES_ERROR_VALUES_LIST
-    )
-    # We only assert if all packages have to exist, which is not true in a reduced source tree
-    assert_defined(${packageEnableVarName})
-    assert_defined(${havePackageUpstreamPackageMacroVarName})
-  endif()
+  assert_defined(${havePackageUpstreamPackageMacroVarName})
   # Set the variables to OFF in local and project-level scopes
   if (NOT "${reasonStr}" STREQUAL "")
     message("-- ${reasonStr}")