Skip to content

Commit 6858da2

Browse files
Revert "Revert "TriBITS Snapshot 2022-12-12 working toward TriBITSPub/TriBITS#63""
This reverts commit ae19a59. This brings back the version of TriBITS snapshotted in Trilinos PR trilinos#11380.
1 parent ef5d8ab commit 6858da2

File tree

733 files changed

+4906
-4782
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

733 files changed

+4906
-4782
lines changed

CMakeLists.txt

+5-1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ INCLUDE(${CMAKE_CURRENT_LIST_DIR}/ProjectName.cmake)
6969
# not in an include file :-(
7070
PROJECT(${PROJECT_NAME} NONE)
7171

72+
# Set up to use ccache
7273
if($ENV{CCACHE_NODISABLE})
7374
# ccache must be requested explicitly by setting env-var CCACHE_NODISABLE
7475
find_program(CCACHE_PROGRAM ccache)
@@ -100,9 +101,12 @@ else()
100101
endif()
101102
endif()
102103

103-
## set an env so we know we are in configure
104+
# Set an env so we know we are in configure
104105
set(ENV{CMAKE_IS_IN_CONFIGURE_MODE} 1)
105106

107+
# Don't define TriBITS override of include_directories()
108+
set(TRIBITS_HIDE_DEPRECATED_INCLUDE_DIRECTORIES_OVERRIDE TRUE)
109+
106110
#
107111
# B) Pull in the TriBITS system and execute
108112
#

cmake/tribits/CHANGELOG.md

+76-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,82 @@
22
ChangeLog for TriBITS
33
----------------------------------------
44

5+
## 2022-12-20:
6+
7+
* **Deprecated:** The macro `set_and_inc_dirs()` is deprecated and replaced by
8+
`tribits_set_and_inc_dirs()`. Use the script
9+
`TriBITS/refactoring/replace_set_and_inc_dirs_r.sh` to update
10+
`CMakeLists.txt` files.
11+
12+
## 2022-11-03:
13+
14+
* **Deprecated:** The long-deprecated TriBITS function override
15+
`include_directories()` now emits a deprecated warning. To replace all
16+
usages of `include_directories()` that should be
17+
`tribits_include_directories()`, use the script
18+
`TriBITS/refactoring/replace_include_directories_r.sh` (see documentation in
19+
that script).
20+
21+
* **Deprecated:** Many previously deprecated TriBITS features now will trigger
22+
a CMake DEPRECATION warning message by default (by calling
23+
`message(DEPRECATION ...)`). The message printed to the CMake output will
24+
typically describe how to remove the usage of the deprecated feature. To
25+
remove deprecation warnings, change to use the non-deprecated features
26+
mentioned in the deprecation warning message. To temporarily disable
27+
deprecation warnings, configure with `-D
28+
TRIBITS_HANDLE_TRIBITS_DEPRECATED_CODE=IGNORE` (see build reference entry
29+
for `TRIBITS_HANDLE_TRIBITS_DEPRECATED_CODE` for more details).
30+
31+
## 2022-10-20:
32+
33+
* **Changed:** Disabling an external package/TPL will now disable any
34+
downstream external packages/TPLs that list a dependency on that external
35+
package/TPL through its
36+
[`FindTPL<tplName>Dependencies.cmake`](https://tribitspub.github.io/TriBITS/users_guide/index.html#findtpl-tplname-dependencies-cmake)
37+
file. Prior to this, disabling an external package/TPL would not disable
38+
dependent downstream external packages/TPLs (it would only disable
39+
downstream dependent required internal packages). To avoid this, simply
40+
leave the enable status of the upstream external package/TPL empty "" and no
41+
downstream propagation of disables will take place.
42+
43+
## 2022-10-16:
44+
45+
* **Removed:** Removed the variables `<Project>_LIBRARY_DIRS`,
46+
`<Project>_TPL_LIST` and `<Project>_TPL_LIBRARIES` from the installed
47+
`<Project>Config.cmake` file. These are not needed after the change to
48+
modern CMake targets `<Package>::all_libs` (see `<Package>::all_libs`
49+
below). To determine if a TPL is enabled, check `if (TARGET
50+
<tplName>::all_libs)`. To get the libraries and include dirs for a TPL,
51+
link against the IMPORTED target `<tplName>::all_libs` (see the updated
52+
TriBITS example APP projects for details).
53+
54+
* **Removed:** Removed the variables `<Package>_PACKAGE_LIST`,
55+
`<Package>_TPL_LIST`, `<Package>_INCLUDE_DIR`, `<Package>_LIBRARY_DIRS`,
56+
`<Package>_TPL_INCLUDE_DIRS`, `<Package>_TPL_LIBRARIES` and
57+
`<Package>_TPL_LIBRARY_DIRS` from the generated `<Package>Config.cmake`
58+
files. These are not needed with the move to modern CMake targets (see
59+
`<Package>::all_libs` below).
60+
61+
* **Changed:** Changed `<Package>_LIBRARIES` in generated
62+
`<Package>Config.cmake` files from the full list of the package's library
63+
targets to just `<Package>::all_libs`. (There is no need to list the
64+
individual libraries after the move to modern CMake targets.)
65+
66+
## 2022-10-11:
67+
68+
* **Changed:** Added option `<Project>_ASSERT_DEFINED_DEPENDENCIES` to
69+
determine if listed external package/TPL and internal package dependencies
70+
are defined within the project or not. The initial default is `FATAL_ERROR`
71+
for development mode and `IGNORE` for release mode. (Previously, undefined
72+
external package/TPL dependencies where ignore.) To set a different
73+
default, set `<Project>_ASSERT_DEFINED_DEPENDENCIES_DEFAULT` to `WARNING`,
74+
for example, in the project's `ProjectName.cmake` file.
75+
76+
* **Removed:** `<Project>_ASSERT_MISSING_PACKAGES` has been removed and setting
77+
it will result in a `FATAL_ERROR`. Instead, use
78+
`<Project>_ASSERT_DEFINED_DEPENDENCIES` (and make sure all of your project's
79+
listed TPL dependencies are all defined within the project).
80+
581
## 2022-10-02:
682

783
* **Changed:** The TriBITS FindTPLCUDA.cmake module changed
@@ -11,7 +87,6 @@ ChangeLog for TriBITS
1187
`find_package(CUDAToolkit)` (see [Trilinos
1288
#10954](https://github.com/trilinos/Trilinos/issues/10954)).
1389

14-
1590
## 2022-09-16:
1691

1792
* **Changed:** Changed nomenclature for packages and TPLs (see updated

cmake/tribits/ci_support/TribitsDumpDepsXmlScript.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -116,8 +116,8 @@ include(TribitsWriteXmlDependenciesFiles)
116116

117117
# Generate the dependencies file
118118

119-
set(${PROJECT_NAME}_ASSERT_MISSING_PACKAGES FALSE)
120-
set(${PROJECT_NAME}_OUTPUT_DEPENDENCY_FILES FALSE)
119+
set(${PROJECT_NAME}_ASSERT_DEFINED_DEPENDENCIES OFF)
120+
set(${PROJECT_NAME}_OUTPUT_DEPENDENCY_FILES FALSE)
121121
if (NOT ${PROJECT_NAME}_PRE_REPOSITORIES) # Make sure is defined!
122122
set(${PROJECT_NAME}_PRE_REPOSITORIES "")
123123
endif()

0 commit comments

Comments
 (0)