Move database path handling from BaseConfig into the SQLite adapter #215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the non-adapter code to avoid references to file paths. This is a small initial step.
because over time there has been some drift from "tenanted config" to "root config" but it's now named "base config" so let's use that name everywhere.
Instead, memoize the adapter in the db config.
adding some temporary duplication in the meantime
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
flavorjones
deleted the
flavorjones/214-move-db-path-into-sqlite-adapter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #204 and #214 we discussed that "path" methods don't belong in
DatabaseConfigurations::BaseConfigbecause the concept of a file path is SQLite-specific.This PR moves path concerns out of BaseConfig and into the SQLite adapter.
There are a few other notable changes in here, too, though:
db_configargument toacquire_ready_lockAs I noted in the comment in
database_adapters/sqlite.rb, I'm not entirely satisfied with how we've extracted the SQLite-specific behavior, because some methods feel like they should be in a database-specific subclass of BaseConfig, and the rest feel like they should be in the Rails database connection adapter. So I think we should continue to refactor this as the opportunity arises!cc @andrewmarkle