ユニットテスト調整 (#3038)

Co-authored-by: Đỗ Văn Hùng <[email protected]>
baserproject · Jan 17, 2024 · 488f7ec · 488f7ec
1 parent 9469bc3
commit 488f7ec
Show file tree

Hide file tree

Showing 57 changed files with 468 additions and 1,006 deletions.
diff --git a/plugins/baser-core/src/Middleware/BcRequestFilterMiddleware.php b/plugins/baser-core/src/Middleware/BcRequestFilterMiddleware.php
@@ -194,7 +194,6 @@ public function isAsset(ServerRequestInterface $request)
      * @return bool
      * @checked
      * @noTodo
-     * @unitTest
      */
     public function isInstall(ServerRequestInterface $request)
     {

diff --git a/plugins/baser-core/src/Model/Behavior/BcUploadBehavior.php b/plugins/baser-core/src/Model/Behavior/BcUploadBehavior.php
@@ -237,7 +237,6 @@ public function beforeDelete(EventInterface $event, EntityInterface $entity, \Ar
      * @return mixed false|array
      * @checked
      * @noTodo
-     * @unitTest
      */
     public function saveTmpFiles($data, $tmpId)
     {

diff --git a/plugins/baser-core/src/TestSuite/BcTestCase.php b/plugins/baser-core/src/TestSuite/BcTestCase.php
@@ -332,7 +332,6 @@ protected function getPrivateProperty(object $class, string $property)
      *
      * @param $events
      * @checked
-     * @unitTest
      * @noTodo
      */
     public function attachEvent($events)
@@ -346,7 +345,6 @@ public function attachEvent($events)
     /**
      * イベントをリセットする
      * @checked
-     * @unitTest
      * @noTodo
      */
     public function resetEvent()

diff --git a/plugins/baser-core/src/Utility/BcComposer.php b/plugins/baser-core/src/Utility/BcComposer.php
@@ -146,7 +146,6 @@ public static function installComposer()
      * @return array
      * @checked
      * @noTodo
-     * @checked
      */
     public static function require(string $package, string $version)
     {

diff --git a/plugins/baser-core/src/Utility/BcUtil.php b/plugins/baser-core/src/Utility/BcUtil.php
@@ -1577,7 +1577,6 @@ public static function fgetcsvReg(&$handle, $length = null, $d = ',', $e = '"')
      * @return array
      * @checked
      * @noTodo
-     * @unitTest
      */
     public static function offEvent(EventManagerInterface $eventManager, string $eventKey)
     {
@@ -1597,7 +1596,6 @@ public static function offEvent(EventManagerInterface $eventManager, string $eve
      * @param EventListenerInterface[] $eventListeners
      * @checked
      * @noTodo
-     * @unitTest
      */
     public static function onEvent(EventManagerInterface $eventManager, string $eventKey, array $eventListeners)
     {

diff --git a/plugins/baser-core/tests/TestCase/Controller/Admin/UsersControllerTest.php b/plugins/baser-core/tests/TestCase/Controller/Admin/UsersControllerTest.php
@@ -284,7 +284,7 @@ public function testDelete()
     {
         $this->enableSecurityToken();
         $this->enableCsrfToken();
-        $this->post('/baser/admin/baser-core/users/delete/1');
+        $this->post('/baser/admin/baser-core/users/delete/2');
         $this->assertResponseSuccess();
         $this->assertRedirect([
             'plugin' => 'BaserCore',

diff --git a/plugins/baser-core/tests/TestCase/Controller/Api/Admin/BcAdminApiControllerTest.php b/plugins/baser-core/tests/TestCase/Controller/Api/Admin/BcAdminApiControllerTest.php
@@ -54,7 +54,7 @@ public function setUp(): void
     public function testInitialize()
     {
         $controller = new BcAdminApiController($this->getRequest());
-        $this->assertTrue(isset($controller->Authentication));
+        $this->assertNotNull($controller->Authentication);
         $this->assertFalse($controller->FormProtection->getConfig('validate'));
     }
 

diff --git a/plugins/baser-core/tests/TestCase/Controller/Api/Admin/UsersControllerTest.php b/plugins/baser-core/tests/TestCase/Controller/Api/Admin/UsersControllerTest.php
@@ -77,8 +77,7 @@ public function testInitialize(){
         $request = $this->getRequest('/baser/api/admin/baser-core/users/');
         $request = $this->loginAdmin($request);
         $usersController = new UsersController($request);
-
-        $this->assertEquals($usersController->Authentication->unauthenticatedActions, ['login']);
+        $this->assertEquals($usersController->Authentication->getUnauthenticatedActions(), ['login']);
     }
 
     public function testLoginAndRefreshToken()

diff --git a/plugins/baser-core/tests/TestCase/Controller/Component/BcCaptchaComponentTest.php b/plugins/baser-core/tests/TestCase/Controller/Component/BcCaptchaComponentTest.php
diff --git a/plugins/baser-core/tests/TestCase/Event/BcEventDispatcherTraitTest.php b/plugins/baser-core/tests/TestCase/Event/BcEventDispatcherTraitTest.php
@@ -51,6 +51,7 @@ public function tearDown(): void
      */
     public function testDispatchLayerEvent()
     {
+        $this->markTestIncomplete('こちらのテストはまだ未確認です');
         $listener = $this->getMockBuilder(BcControllerEventListener::class)
             ->onlyMethods(['implementedEvents'])
             ->addMethods(['testTest'])

diff --git a/plugins/baser-core/tests/TestCase/Middleware/BcRequestFilterMiddlewareTest.php b/plugins/baser-core/tests/TestCase/Middleware/BcRequestFilterMiddlewareTest.php
@@ -204,6 +204,7 @@ public static function isAssetDataProvider()
      */
     public function testIsInstall($expect, $url)
     {
+        $this->markTestIncomplete('こちらのテストはまだ未確認です');
         Configure::write('BcRequest.isInstalled', false);
         $this->assertEquals($expect, $this->BcRequestFilterMiddleware->isInstall($this->getRequest($url)));
     }

diff --git a/plugins/baser-core/tests/TestCase/Model/Behavior/BcUploadBehaviorTest.php b/plugins/baser-core/tests/TestCase/Model/Behavior/BcUploadBehaviorTest.php
@@ -181,6 +181,7 @@ public function testAfterSave()
      */
     public function testSaveTmpFiles()
     {
+        $this->markTestIncomplete('こちらのテストはまだ未確認です');
         touch($this->uploadedData['eyecatch']['tmp_name']);
         $entity = $this->BcUploadBehavior->saveTmpFiles($this->uploadedData, 1);
         $tmpId = $this->BcUploadBehavior->BcFileUploader[$this->table->getAlias()]->tmpId;