Blog helper test categories #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ryuring |
|
一旦、担当を戻しておきますね @nghiem-mb |
ryuring
requested changes
Jan 17, 2024
| @@ -424,6 +425,7 @@ public function test__getCategoryList() | |||
| 'fields' => $fields, | |||
| 'depth' => 2, | |||
| ]); | |||
| // dd($result->toArray()[0]->children); | |||
| @@ -268,6 +268,7 @@ protected function _getCategoryList( | |||
| if ($distinct) { | |||
| $query->distinct($distinct); | |||
| } | |||
| $query->matching('BlogPosts.BlogContents.Contents'); | |||
There was a problem hiding this comment.
@nghiem-mb これは使い方が違う気がします。全ての条件において無理やり inner join で繋げることになり負荷が高くなるので、必要な時だけ使うように調整してください。
ryuring
requested changes
Jan 17, 2024
| @@ -268,6 +268,9 @@ protected function _getCategoryList( | |||
| if ($distinct) { | |||
| $query->distinct($distinct); | |||
| } | |||
| if ($options['siteId'] !== false && !is_null($options['siteId'])) { | |||
There was a problem hiding this comment.
@nghiem-mb 238行目にまとめることはできませんか？
There was a problem hiding this comment.
@nghiem-mb 以前共有したこちらのコードを参考にお願いします。
$query->matching('BlogPosts.BlogContents.Contents', function ($q) use ($params) {
return $q->where(['Contents.site_id' => $params['siteId']]);
});
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.