Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unecessary conditionals in Readme #38

Open
jsmartin opened this issue Feb 4, 2016 · 4 comments
Open

Unecessary conditionals in Readme #38

jsmartin opened this issue Feb 4, 2016 · 4 comments
Assignees

Comments

@jsmartin
Copy link
Collaborator

jsmartin commented Feb 4, 2016

Unless I'm mistaken, you won't need the when: riak_ring_status.stdout.find('joining') > 0 under the Riak module section, should already be taken care of in the module: https://github.com/ansible/ansible-modules-extras/blob/devel/database/misc/riak.py#L197

@christophermancini
Copy link
Contributor

So, the functionality the check status and conditional provide is not in the module. However, it might be a good idea to add it to the module unless its ok for Plan to error out. What do you think is the most consistent expected behavior for ansible users?

@christophermancini
Copy link
Contributor

@jsmartin I realized I never tagged you in my previous comment. Do you have any thoughts?

@jsmartin
Copy link
Collaborator Author

I'd say it would be cleaner if it existed in the module itself. Less conditionals in the Ansible content would make it look a lot cleaner.

@christophermancini
Copy link
Contributor

I agree, I will get it added to the work queue. Thanks @jsmartin

@christophermancini christophermancini self-assigned this Apr 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants