Error handling in python client [JIRA: CLIENTS-667]

[seancribbs]

Moved from https://issues.basho.com/show_bug.cgi?id=385, reported by Mehmet Ali Akmanalp

It looks like it's hard to handle or even notice errors with the python client. Here's a prime example:

import riak

c = riak.RiakClient("127.0.0.1", 8087, transport_class=riak.RiakPbcTransport)

b = c.bucket("")
o = b.new("")
o.set_data({"foo":1, "bar": 4})
o.store()

This runs silently. No exceptions are thrown. I don't know what it did. I can't check any of the return values because they mostly return "self". There seems to be a RiakError but that's a more generic "oh crap something went terribly wrong" whereas the sort of granularity people would want (IMHO) is "the database connection failed" (which throws a socket.error by the way) or "x does not exist".

Thanks,
~mali

[chason]

Is this fixed? I just attempted this, and got an socket.error on o.store(), which seems to be the right time to throw that error.

[evanmcc]

IMO it still needs a more comprehensive review.

[shuhaowu]

Agreed. I think i might have brought this up somewhere before.

[shuhaowu]

Do we have an update on this? Another thing is if the connection failed, we don't actually know until we do something like o.exists

>>> import riak
>>> c = riak.RiakClient(host="127.0.0.1", http_port=8888)
>>> b = c.bucket("test")
>>> o = b.new("test")
>>> o.store()
<riak.riak_object.RiakObject object at 0x1ddffd0>
>>> o.exists
False
>>> 

Idiomatic python usually involves exceptions.

[pigmej]

Same applies to siblings.

I would really expect to have exception when bucket has allow_mult enabled and there is sibling detected. Without that I have to do if obj.siblings in every place where I might have them.

[seancribbs]

@pigmej I have WIP addressing the siblings issue.

[furushchev]

any update ?

cc: @k-okada