-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adaptive_lighting.set_manual_control doesn't have the expected outcome #37
Comments
That sounds like a bug, could you perhaps turn on logging and share the logs after the problem occurs? See https://github.com/basnijholt/adaptive-lighting#having-problems |
Log attached. The bedroom lights are off, and the log starts when I press automation which turns on the "turn on at 1% brightness" scene (excerpted below).
|
I have the exact same issue. Set up an automation to enable manual control of certain light on button press, manual control shows up as “working” when checking the switch, hover the lights keep getting adapted. Edit: in fact, when changing the settings of adaptive_lighting, neither “take_over_control” or “detect_non_ha_changes” seems to stop lights from being adapted. The only setting that stops adaption is “only_once” |
FYI @RichEsq I’ve found a way around it for now by enabling/disabling the adaptive lighting switch of the corresponding room. Something like:
And then automatically enabling the switch back on whenever lights are turned off to re-enable adaptive lighting:
Not perfect (if you have multiple lights or rooms in a single adaptive lighting instance they’ll lose adaptive lighting as well), but usable (I’ve split them up per room) until the bug is fixed |
Issue persists in latest version (008c5e4), set_manual_control doesn’t seem to be doing anything. |
@gvssr, could you elaborate on that please? In both my personal setup and in the tests the |
@basnijholt Maybe I’m doing it wrong or having the wrong expectations. Example I just tried: Setup Steps
I can see it succeeded when I open up the entity switch.adaptive_lighting_woonkamer, which notes manual control is set for light.woonkamer_eettafel_lamp. I change the brightness of that lamp using HA. Expected behavior Actual behavior |
I think this may be related, as it's also related to manual control - if I set a light to manual control while it is off, when it is turned on, it automatically gets called to adaptive lighting, even though it was already marked as manually controlled. This seems counterintuitive to the readme where it says:
If an automation or scene is calling the light (especially if calling it with custom values), that would suggest that it is manually controlled, right? There doesn't seem to be a good workaround for this in the case of the transition from a light being off to wanting it to go directly to a RGB color, for example. |
If it´s not a bug, my proposal from #89 (comment):
Currently I´m testing to apply the manual_control in my automation, for the moment it seems to work:
Use-Case is in #89 (comment). |
I'm currently in the process of doing version 2. This will be added/fixed. Keep this ticket open until you can verify that it's properly working in the upcoming version 2. |
I've confirmed this is fixed in the current version. |
I have a series of Philips Hue 4 button switches, and have traditionally used the "dim" button to set the lights to 1% brightness, no matter their current state. (eg if they're off, they turn on with 1% brightness).
This works fine with adaptive lighting if the lights are already on, but if the lights are off, the act of turning them on triggers adaptive lighting. I've tried working around this by setting "adaptive_lighting.set_manual_control" to "true" in my automation before calling the "dim" scene but it doesn't seem to work - the lights still come on at "full" brightness.
Example automation below.
The text was updated successfully, but these errors were encountered: