-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config options to adjust brightness profile shape #94
Comments
One correction: the "brightness scale-factor" should only affect the delta from the max brightness. In other words, the percent = 1 + percent
return (delta_brightness * percent) + self.min_brightness with return max(self.brightness + round(brightness_scale_factor*(delta_brightness * percent)), self.min_brightness) Note that in the replacement, |
Hey @edgimar, can you explain your use case and why this would help you? :) |
Yes I seen to have left out that key piece of info! I am already using the 'brightness scale factor' change locally, and the reason is because otherwise the brightness values never get low enough to make my bulbs as dim as I'd like at the times I want them dim. |
Check out the new This should give you enough control to separate brightness and color. Some more examples: |
Check out this new webapp to visualize the parameters https://basnijholt.github.io/adaptive-lighting/ adaptive-lighting.mp4 |
It would be nice if there were a brightness scale-factor that causes the 'normal' computed brightness-percent value
X
to be replaced bymax(round(s*X), min_brightness)
, wheres
is the scale factor.OR
if you want to get fancy, you could allow the user to choose either of the following:
The text was updated successfully, but these errors were encountered: