-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to update hue scenes based on a keywork #1019
base: main
Are you sure you want to change the base?
Conversation
@th3w1zard1 Hi, please have a look to this PR, you were interested into this implementation |
Well that was quite a rabbit hole of information I had forgotten about. I am not familiar with the async code you're using. Usually we use hassio's api as migrating to other async implementations have caused bugs in the past. I know next to nothing about that. other than that your implementation looks good. You are creating yet another attr, ensuring existing functionality will persist, showing a clear understanding of our process. |
@th3w1zard1 Thanks for the feedback, I'll now try to cleanup my PR, making tests pass. I don't know how I can properly document this functionality to make it clear for everyone. For the main logic I know its robust, I use it since 2022 with another custom_integration (claytonjn/hass-circadian_lighting#195) |
Hum there is a bug values aren't updated with daylight, it's probably out of range values of hue bridge, I'll check that |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I've added a delays of 5 minutes between same keyword update to avoid overloading the bridge. |
This PR will let you set a keyword to search in your scenes list and update the set brightness and colortemp without changing power state.
It is usefull when you use Hue Bridge and you set your buttons to a scene.
It is not working with multiple bridge instance, it will only update the first bridge, this behaviour is easy to fix but I don't have a second bridge make tests
Usage exemple:
AL_living room celling light
,AL_living room table top light
,AL_living room all lights
with the lights you want to be turned on.AL_living room
as keyword and all living room scenes will be updateSolves #271