Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new member in the bats-detik team #38

Open
vincent-zurczak opened this issue Jul 5, 2022 · 1 comment
Open

Add a new member in the bats-detik team #38

vincent-zurczak opened this issue Jul 5, 2022 · 1 comment
Assignees

Comments

@vincent-zurczak
Copy link
Member

Hello,

I have a pull request opened for quite some time now. I know @martin-schulze-vireso said several times in previous PRs that he was not confident enough about the impact of changes. And I guess the same happen with others. This is why I suggest onboarding a new contributor on the project, at least to help in code reviews.

If you agree, one of my team mates, @pascallibenzi, would be glad to join us.
We work for the same company. He knows the project and is skilled enough with both Kubernetes and BASH to become a committer. That would also prevent me from being the SPOF of this project.

@martin-schulze-vireso
Copy link
Member

martin-schulze-vireso commented Jul 5, 2022

As is, the account is pretty much a clean slate and would have to earn my trust, for me to vote them into the team.

If you only need a reviewer, then your colleague can do so without special privileged. After their approval, I can approve too, to allow the merge. This can build the trust for further steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants