Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Airplane types are not unique in flight results #6

Open
bauerj opened this issue Dec 19, 2019 · 2 comments
Open

Airplane types are not unique in flight results #6

bauerj opened this issue Dec 19, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@bauerj
Copy link
Owner

bauerj commented Dec 19, 2019

Google Flights shows which plane is planned to be used for a given flight. However, this in not really precise as one plane could match multiple planes in Atmosfair's API.

For example:

  • Flight QR 816 is shown as flying a Boeing 777. Atmosfair however distinguishes between Boeing 777-200, Boeing 777-200LR, Boeing 777-300 and Boeing 777-300ER.
  • Flight AY 99 uses an Airbus A350. Atmosfair knows the Airbus A350-1000 or Airbus A350-900

It is not clear which plane should be used to calculate the specific emissions. Currently, no plane type is sent in this case which results in a higher margin of error for the emission estimation.

@bauerj bauerj added the enhancement New feature or request label Dec 19, 2019
@mmathea-ep
Copy link
Collaborator

One possible solution is to use the flight number instead of the planes type. A request with flightnumber looks like
{ "accountId": „...", "password":"...", "flights": [ { "flightNumber":"UA988", "departureDate":"2018-10-03", "passengerCount": 1, "flightCount": 2, "travelClass": "B", "charter": false } ] }

If no response is received or the response is insufficent it is okay to approximate or more precisely use the current logic.

@mmathea-ep
Copy link
Collaborator

For the current case a mapping is a better solution than to use no planetype. I will add a mapping to the current candidates.

@bauerj bauerj self-assigned this Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants