Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rules_proto dependency (now deprecated) #4205

Closed
kgreenek opened this issue Dec 29, 2024 · 4 comments
Closed

Remove rules_proto dependency (now deprecated) #4205

kgreenek opened this issue Dec 29, 2024 · 4 comments

Comments

@kgreenek
Copy link

The rules_proto repository has been deprecated and should no longer be used.
See: https://github.com/bazelbuild/rules_proto?tab=readme-ov-file#protobuf-rules-for-bazel

As of v0.1.0, rules_cc removed all protobuf rules and they are now part of com_google_protobuf instead (as of v29.0).
See:

https://github.com/protocolbuffers/protobuf/releases/tag/v29.0
https://github.com/bazelbuild/rules_cc/releases/tag/0.1.0

All instances of:

load("@rules_proto//proto:defs.bzl", "proto_library")

should be replaced with:

load("@com_google_protobuf//bazel:proto_library.bzl", "proto_library")
@czezi
Copy link

czezi commented Jan 1, 2025

+1

@fmeum
Copy link
Member

fmeum commented Jan 1, 2025

Updating the references to protobuf would force users to update their version of protobuf to a pretty recent version. Since we still support Bazel 6, we will probably stay on rules_proto for a while, which does forward to protobuf.

Does this cause any issues for you or is this just meant as a suggestion for cleanup?

@kgreenek
Copy link
Author

kgreenek commented Jan 2, 2025

I had thought it was causing an issue but it turned out to be something else.

So this would just be a cleanup.

@fmeum
Copy link
Member

fmeum commented Jan 2, 2025

I'll close this for now as we would only need to update when forced and Bzlmod makes it so that depending on old versions provides users with the highest degree of freedom.

@fmeum fmeum closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants