-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OSX tests #211
Fix OSX tests #211
Conversation
Ah, so it looks like this works on Bazel 6.x but not 5.1.0. I believe bazelbuild/bazel@33e7261 added support for the libtool feature in a 6.0pre (May 2022). How do you feel about bumping min bazel to 6.0, or would you rather hold of until 7.0 ships? |
6.0 for minimum supported version is fine. People can always hold off on updating to a new release of this repo, there have not been that many changes. Will you be able to update the tests and the documentation? |
Yep just kicked off a run, let's see if it works |
@dzbarsky Are you able to merge these changes yourself? I forgot what the settings on this repo are, and I no longer have access to them. |
Don't think I have permission to merge, I'd need write access. |
I will see if I can talk to someone with my previous employer to give me admin access again. |
alternatively we could consider migrating this repo to bazel-contrib? See https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html for requirements for doing that. |
Sounds good. There are 3 bazel related repos in the grailbio org, that I don't think anyone actively maintains anymore. I will see if we can get them transferred over to bazel-contrib. |
@siddharthab Sorry about missing this in the previous PR, I hadn't bothered checking if we had OSX tests