Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OSX tests #211

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix OSX tests #211

merged 1 commit into from
Sep 1, 2023

Conversation

dzbarsky
Copy link
Contributor

@dzbarsky dzbarsky commented Sep 1, 2023

@siddharthab Sorry about missing this in the previous PR, I hadn't bothered checking if we had OSX tests

@dzbarsky
Copy link
Contributor Author

dzbarsky commented Sep 1, 2023

Ah, so it looks like this works on Bazel 6.x but not 5.1.0. I believe bazelbuild/bazel@33e7261 added support for the libtool feature in a 6.0pre (May 2022). How do you feel about bumping min bazel to 6.0, or would you rather hold of until 7.0 ships?

@siddharthab
Copy link
Contributor

6.0 for minimum supported version is fine. People can always hold off on updating to a new release of this repo, there have not been that many changes.

Will you be able to update the tests and the documentation?

@dzbarsky
Copy link
Contributor Author

dzbarsky commented Sep 1, 2023

Yep just kicked off a run, let's see if it works

@siddharthab
Copy link
Contributor

@dzbarsky Are you able to merge these changes yourself? I forgot what the settings on this repo are, and I no longer have access to them.

tests/.bazelrc Show resolved Hide resolved
@dzbarsky
Copy link
Contributor Author

dzbarsky commented Sep 1, 2023

Don't think I have permission to merge, I'd need write access.

@siddharthab
Copy link
Contributor

Don't think I have permission to merge, I'd need write access.

I will see if I can talk to someone with my previous employer to give me admin access again.

@siddharthab siddharthab merged commit 9d8cc8a into bazel-contrib:master Sep 1, 2023
17 checks passed
@jsharpe
Copy link
Member

jsharpe commented Sep 1, 2023

Don't think I have permission to merge, I'd need write access.

I will see if I can talk to someone with my previous employer to give me admin access again.

alternatively we could consider migrating this repo to bazel-contrib? See https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html for requirements for doing that.

@siddharthab
Copy link
Contributor

Don't think I have permission to merge, I'd need write access.

I will see if I can talk to someone with my previous employer to give me admin access again.

alternatively we could consider migrating this repo to bazel-contrib? See https://bazel-contrib.github.io/SIG-rules-authors/hosting-policy.html for requirements for doing that.

Sounds good. There are 3 bazel related repos in the grailbio org, that I don't think anyone actively maintains anymore. I will see if we can get them transferred over to bazel-contrib.

@dzbarsky dzbarsky deleted the fix-tests branch October 4, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants