Skip to content

Commit

Permalink
Fix named split
Browse files Browse the repository at this point in the history
  • Loading branch information
jerrymarino committed Aug 11, 2023
1 parent 630d536 commit 641db28
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion rules/test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def _make_test_suite_splits(factory, name, **in_kwargs):
Finally - you can set the splits to be whatever you want.
"""
split_name_to_kwargs = in_kwargs.get("split_name_to_kwargs", {})
split_name_to_kwargs = in_kwargs.pop("split_name_to_kwargs", {})
splits = {}
if split_name_to_kwargs and len(split_name_to_kwargs) > 0:
for suffix, split_kwargs in split_name_to_kwargs.items():
Expand Down Expand Up @@ -174,6 +174,9 @@ def _ios_test(name, bundle_rule, test_rule, test_factory, apple_library, infopli
else:
ios_test_kwargs["runner"] = runner

if split_name_to_kwargs:
ios_test_kwargs["split_name_to_kwargs"] = split_name_to_kwargs

# Deduplicate against the test deps
if ios_test_kwargs.get("test_host", None):
host_args = [ios_test_kwargs["test_host"]]
Expand Down

0 comments on commit 641db28

Please sign in to comment.