From 641db2897f03d99909b4f70de64bc0b158240191 Mon Sep 17 00:00:00 2001 From: Jerry Marino Date: Thu, 10 Aug 2023 17:05:55 -0700 Subject: [PATCH] Fix named split --- rules/test.bzl | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/rules/test.bzl b/rules/test.bzl index 0278b9300..54ddf3046 100644 --- a/rules/test.bzl +++ b/rules/test.bzl @@ -66,7 +66,7 @@ def _make_test_suite_splits(factory, name, **in_kwargs): Finally - you can set the splits to be whatever you want. """ - split_name_to_kwargs = in_kwargs.get("split_name_to_kwargs", {}) + split_name_to_kwargs = in_kwargs.pop("split_name_to_kwargs", {}) splits = {} if split_name_to_kwargs and len(split_name_to_kwargs) > 0: for suffix, split_kwargs in split_name_to_kwargs.items(): @@ -174,6 +174,9 @@ def _ios_test(name, bundle_rule, test_rule, test_factory, apple_library, infopli else: ios_test_kwargs["runner"] = runner + if split_name_to_kwargs: + ios_test_kwargs["split_name_to_kwargs"] = split_name_to_kwargs + # Deduplicate against the test deps if ios_test_kwargs.get("test_host", None): host_args = [ios_test_kwargs["test_host"]]