Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule removing unideal features: move them to incompatible #631

Open
jerrymarino opened this issue Dec 21, 2022 · 0 comments
Open

Schedule removing unideal features: move them to incompatible #631

jerrymarino opened this issue Dec 21, 2022 · 0 comments

Comments

@jerrymarino
Copy link
Contributor

jerrymarino commented Dec 21, 2022

A lot of the features we added here were only features / conditional because they were in-development and I often want to encourage people to work iteratively. Some features should eventually transition to be removed to reduce complexity and keep rules_ios lightweight

Because of this - we have some features that should be removed - and we have to maintain complexity while they stay around. My proposal is:

  1. develop a feature - by adding --features apple.enable_awesome_feature
  2. default the feature to enabled - and then
    2a. if the feature isn't deemed ideal to keep around, then schedule it for removal.
    2b. the feature scheduled for should follow Bazel's incompatible pattern - to encourage
    people to flag issues with us.:
    apple.enable_awesome_feature -> apple.incompatible_disable_awesome_feature

Related is this thread about enabling defaults: #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant