Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and use latest archives #784

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

luispadron
Copy link
Collaborator

@luispadron luispadron commented Oct 19, 2023

Updates the dependencies of the latest versions, fixes some bzlmod warnings introduced by rules_apple 3 PR

WARNING: For repository 'build_bazel_apple_support', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'build_bazel_rules_swift', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.

Additionally, moves the latest versions in repositories.bzl back to using the release archive instead of a GitHub on-demand archive. Not sure why those were changed

Finally, fixes issues with stardoc and rules_apple 3 + bzlmod.
It re-enables bzlmod for stardoc in CI

Fixes #783

Copy link
Contributor

@jerrymarino jerrymarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luispadron thanks for updating it 👍

@luispadron
Copy link
Collaborator Author

A new rules_apple & rules_swift version will be tagged soon that include some stardoc fixes (which is why they're failing here) ill update this pr when theyre done.

We essentially need: bazelbuild/rules_apple#2292

@jerrymarino
Copy link
Contributor

jerrymarino commented Oct 19, 2023

Ok thanks - I've filed an issue for the problems we ran into after the stardoc update at:
#783

@luispadron luispadron force-pushed the luis/update-dependencies-use-release-archives branch 2 times, most recently from b7b957c to 1644e0b Compare October 19, 2023 21:05
@luispadron
Copy link
Collaborator Author

Updated the PR to include rules_apple 3.1.0 and rules_swift 1.13.0 which fixes the issues we were seeing with stardoc and bzlmod. CI is now back to using bzlmod for the stardoc tests

Updates the dependencies of the latest versions, fixes some bzlmod warnings introduced by rules_apple 3 PR

```
WARNING: For repository 'build_bazel_apple_support', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
WARNING: For repository 'build_bazel_rules_swift', the root module requires module version [email protected], but got [email protected] in the resolved dependency graph.
```

Additionally, moves the latest versions in `repositories.bzl` back to using the release archive instead of a git clone. Not sure why those were changed

Finally, fixes issues with stardoc and rules_apple 3 + bzlmod.
It re-enables bzlmod for stardoc in CI
@luispadron luispadron force-pushed the luis/update-dependencies-use-release-archives branch from 1644e0b to b2d3bf9 Compare October 19, 2023 21:39
@luispadron
Copy link
Collaborator Author

Updated again to rules_apple 3.1.1 which brings one final fix for non bzlmod users. This should be ready now, @jszumski @thiagohmcruz when ya'll have a minute

@luispadron luispadron merged commit 7b07ab6 into master Oct 20, 2023
9 checks passed
@luispadron luispadron deleted the luis/update-dependencies-use-release-archives branch October 20, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues w/stardoc + bzlmod: currently runnning stardoc w/o bzlmod
3 participants