Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --incompatible_objc_provider_remove_linking_info #867

Open
luispadron opened this issue Apr 10, 2024 · 1 comment
Open

Support --incompatible_objc_provider_remove_linking_info #867

luispadron opened this issue Apr 10, 2024 · 1 comment

Comments

@luispadron
Copy link
Collaborator

luispadron commented Apr 10, 2024

In Bazel 7 a new flag: --incompatible_objc_provider_remove_linking_info was added to further delete these link attrs from the ObjcProvider making it an error if the attr is used or set. This will be flipped in a future Bazel version (probably Bazel 8). We should update our rules to conditionally forward ObjcProvider linking information to support this flag.

@luispadron luispadron changed the title Support --incompatible_objc_linking_info_migration Support --incompatible_objc_provider_remove_linking_info Apr 10, 2024
@luispadron
Copy link
Collaborator Author

Example error you'd see with this flag enabled:

ERROR: /Users/lpadron/Development/rules_ios/tests/ios/app-clip/BUILD.bazel:39:16: in dep_middleman rule //tests/ios/app-clip:App.dep_middleman: 
Traceback (most recent call last):
        File "/Users/lpadron/Development/rules_ios/rules/internal/framework_middleman.bzl", line 267, column 73, in _dep_middleman
                objc_provider_fields = objc_provider_utils.merge_objc_providers_dict(providers = objc_providers, merge_keys = [
        File "/Users/lpadron/Development/rules_ios/rules/internal/objc_provider_utils.bzl", line 28, column 34, in _merge_objc_providers_dict
                transitive = [getattr(provider, key) for provider in providers],
Error in getattr: 'ObjcProvider' value has no field or method 'force_load_library'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant