Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect UIDeviceFamily inside Info.plist produced by precompiled_apple_resource_bundle for watchOS #923

Closed
vakhidbetrakhmadov opened this issue Sep 24, 2024 · 0 comments · Fixed by #924 or revolut-mobile/rules_ios#7
Closed

Incorrect UIDeviceFamily inside Info.plist produced by precompiled_apple_resource_bundle for watchOS #923

vakhidbetrakhmadov opened this issue Sep 24, 2024 · 0 comments · Fixed by #924 or revolut-mobile/rules_ios#7

Comments

@vakhidbetrakhmadov
Copy link
Contributor

I have the following setup:

ios_application (A) -> watchos_application (B) -> watchos_extension (C) -> swift_library (D) -> precompiled_apple_resource_bundle (E)

When i look inside A.app/Watch/B.app/PlugIns/C.appex/E.bundle/Info.plist, i see

...
"UIDeviceFamily" => [
    0 => 1
    1 => 2
]
...

while what i expect to see is:

...
"UIDeviceFamily" => [
    0 => 4
]
...
vakhidbetrakhmadov pushed a commit to vakhidbetrakhmadov/rules_ios that referenced this issue Sep 24, 2024
Select device_families by platform_type in precompiled_apple_resource…
383c3ab 
…_bundlei (fixes bazel-ios#923)
vakhidbetrakhmadov pushed a commit to vakhidbetrakhmadov/rules_ios that referenced this issue Sep 24, 2024
Select device_families by platform_type in precompiled_apple_resource…
ac2ed50 
…_bundle (fixes bazel-ios#923)
@vakhidbetrakhmadov vakhidbetrakhmadov mentioned this issue Sep 24, 2024
Merged
vakhidbetrakhmadov pushed a commit to vakhidbetrakhmadov/rules_ios that referenced this issue Sep 24, 2024
Select device_families by platform_type in precompiled_apple_resource…
1c828e5 
…_bundle (fixes bazel-ios#923)
vakhidbetrakhmadov pushed a commit to vakhidbetrakhmadov/rules_ios that referenced this issue Sep 25, 2024
Select device_families by platform_type in precompiled_apple_resource…
09edcb6 
…_bundle (fixes bazel-ios#923)
@vakhidbetrakhmadov vakhidbetrakhmadov mentioned this issue Sep 25, 2024
Merged
acecilia pushed a commit to revolut-mobile/rules_ios that referenced this issue Sep 25, 2024
@vakhidbetrakhmadov
Select device_families by platform_type in precompiled_apple_resource…
15f81ec 
…_bundle (fixes bazel-ios#923) (#7)

Co-authored-by: Vakhid Betrakhmadov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@vakhidbetrakhmadov