Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kotlin Metadata is unchanged #46

Open
thomasbao12 opened this issue Jan 25, 2024 · 0 comments
Open

Kotlin Metadata is unchanged #46

thomasbao12 opened this issue Jan 25, 2024 · 0 comments

Comments

@thomasbao12
Copy link

thomasbao12 commented Jan 25, 2024

Even using the latest commit 57067a1beec4ce5c7ee97ec25bb666b6fad6b160, bazel_jar_jar will not update the kotlin metadata in the bytecode.

Repro:

jar_jar(
    name = "graphql_kotlin_schema_generator_shaded",
    inline_rules = ["rule graphql.** graphql13.@1"],
    input_jar = "@maven//:com_expediagroup_graphql_kotlin_schema_generator",
    visibility = ["//visibility:private"],
)

where this is the resolved maven coordinate: ("com.expediagroup", "graphql-kotlin-schema-generator", "1.0.0-RC11").

IF you look at the shaded jar, you'll see the following

Screenshot 2024-01-24 at 4 30 00 PM Screenshot 2024-01-25 at 2 18 58 PM

Note that the import statement is changed correctly, but the kotlin metadata d2 field is not.

This will lead to compilation errors, where the inferred type and expected type do not match.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant