Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serve() never ends - Consider a ServeContext() that takes context.Context? #306

Open
Vaelatern opened this issue Dec 11, 2024 · 0 comments · May be fixed by #307
Open

Serve() never ends - Consider a ServeContext() that takes context.Context? #306

Vaelatern opened this issue Dec 11, 2024 · 0 comments · May be fixed by #307

Comments

@Vaelatern
Copy link

Pretty much as the description states. Would you consider accepting a PR that works a context.Context into the loop in Serve() function? That way if the program needs to terminate, including the mount it triggered, it could unmount the filesystem safely?

@Vaelatern Vaelatern linked a pull request Dec 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant