Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make undo-tree possible to disable #1424

Closed
ryukinix opened this issue Dec 12, 2024 · 5 comments · Fixed by #1428
Closed

Make undo-tree possible to disable #1424

ryukinix opened this issue Dec 12, 2024 · 5 comments · Fixed by #1428
Labels

Comments

@ryukinix
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'm considering replacing undo-tree with vundo due performance issues.

Describe the solution you'd like

Make possible to disable undo-tree, which is enabled by default.

Describe alternatives you've considered

Create a variable to toggle if undo-tree should be enabled, around these lines:

https://github.com/bbatsov/prelude/blob/master/core%2Fprelude-editor.el#L361-L368

It can be enabled by default to be a backward compatible change, but it should be possible to customize on user personal config.

@ryukinix
Copy link
Contributor Author

I can do this if there is no objections.

Copy link

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed soon if no further activity occurs. Thank you for your contribution and understanding!

@github-actions github-actions bot added the stale label Jan 19, 2025
@ryukinix
Copy link
Contributor Author

I'm waiting for someone feedback to properly implement that, but it seems is not something interesting to anyone, so probably I'll only change things for me.

@bbatsov
Copy link
Owner

bbatsov commented Jan 19, 2025

A configuration variable is a good approach IMO. (and it's consistent with how we normally do things)

@ryukinix
Copy link
Contributor Author

Ok @bbatsov, opened at #1428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants