Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaPlayer Cannot read property 'duration' of null - Storybook error #198

Open
pietrop opened this issue Oct 2, 2019 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@pietrop
Copy link
Contributor

pietrop commented Oct 2, 2019

Describe the bug

as noticed by @emettely when going to MediaPlayer in storybook get error Cannot read property 'duration' of null

To Reproduce
Steps to reproduce the behavior:

  1. Go to demo app MediaPlayer https://bbc.github.io/react-transcript-editor/?path=/story/mediaplayer--default
  2. See error Cannot read property 'duration' of null - see screenshot below

Expected behavior

Not see an error when looking at MediaPlayer in storybook

Screenshots

in current master

Screenshot 2019-10-02 at 18 22 57

Additional context

Likely to be just to do with initialisation of MediaPlayer component in storybook.

Via @emettely

Original that worked: 9557faa0f66c4abb711301e2fc94fdcd5f48dc4c
Change that introduced bug to story: 45c324dc1dcd2fdd3ca94b1e14a699eab11587e0
so it’s between those two hashes some changes have been introduced

@pietrop pietrop added the bug Something isn't working label Oct 2, 2019
@pietrop pietrop changed the title MediaPlayer Cannot read property 'duration' of null MediaPlayer Cannot read property 'duration' of null - Storybook error Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants