-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #200 component save #201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating from BBC repo
removing functions to save and adding callback at parent component
only works with laodDemo, other import from computer etc.. still not addressed
…nscript-editor into fix-200-component-save
emettely
reviewed
Oct 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for updating the docs + demos also. If I understood correctly, the AutoSaveChanges is what gives the file extension? Not so sure if the autoSaveFormat
is an option that you would want to be able to configure.
Anyways, I have one code suggestion (see below).
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
#200
Describe what the PR does
Option 1 in #200 (comment)
Adds the following attributes to
TranscriptEditor
handleAutoSaveChanges
handleAutoSaveChanges
,falls back onsttJsonType
. ordraftjs
fileName
is no longer used as key to store and retrieve from local storage, but is still in use when exporting transcript in various formats. and it's still optional.onChange
to auto save inTimedTextEditor
was trigger a bit too often, as it was not inside the check to see if the content of draftJs had changed (this.state.editorState.getCurrentContent() !== editorState.getCurrentContent()
) so moved it to only be triggered if content has been modified (inserted, deleted etc..)TranscriptEditor
storybook (http://localhost:6006/?path=/story/transcripteditor--default
)setState
is async so changed the logic to use result ofupdateTimestampsForEditorState
when returning data for autoSave.local-storage.js
under the demo app, consider whether it's work, in a separate PR, showcase how local storage save would work in the demo app etc.. I'd say low priority tho?State whether the PR is ready for review or whether it needs extra work
Ready for review
Additional context
related Issue
#176
PRs
#177
#199
Once this PR is merged it be good to