Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image capture more fault-tolerant #494

Open
kentr opened this issue Dec 4, 2016 · 0 comments
Open

Make image capture more fault-tolerant #494

kentr opened this issue Dec 4, 2016 · 0 comments

Comments

@kentr
Copy link

kentr commented Dec 4, 2016

I've been hitting intermittent failures with some paths and running into problems with incomplete directories in the shots folder, so I looked into the error handling a bit and have some questions.

It appears that save_image.rb does have the fallback to using the "invalid image", but it's not working in some cases.

For me, looks like it's because image_was_created() returns true if the mode is resize, even if the image wasn't actually created.

Tracing that, I noticed that attempt_image_capture() is trying to capture images with MULTI_...png in the name, and from looking at _helper.js I gather that the MULTI_...png filename is just a placeholder and not meant to be an actual file.

Is it correct that there aren't supposed to be actual result images named MULTI_...png ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant