Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery still shows diffs which are less then threshold set in "diff_only" mode #512

Closed
4 tasks
warrenjarm opened this issue Mar 9, 2017 · 1 comment
Closed
4 tasks

Comments

@warrenjarm
Copy link

warrenjarm commented Mar 9, 2017

Hi,

I have installed the latest version of Wraith via "gem install" on my Mac. It works as expected, however when setting the threshold to any value (e.g. 5%) and using "diff_only" mode, the gallery.html still shows all the diffs. I would expect the gallery to only display diffs above 5%.

Should the "diff_only" mode only show diffs or is it expected that it show all diffs?

Cheers,
Warren


Reporting a problem? Please describe the issue above, and complete the following checklist so that we can help you more quickly.

Issue checklist:

  • I have validated my config file against YAML Validator to make sure it is valid YAML.

  • I have run the wraith info command and pasted the output below:

paste results here
  • I have run the command in verbose mode (by adding verbose: true to my config) and pasted the output below:
paste results here
  • I have pasted the contents of my config file below:
paste config here
@ChrisBAshton
Copy link
Contributor

Thanks for taking the time to raise an issue. This is a duplicate of #507.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants