Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for invalid WebSocket URL #617

Open
adashrod opened this issue Nov 16, 2024 · 0 comments
Open

Error message for invalid WebSocket URL #617

adashrod opened this issue Nov 16, 2024 · 0 comments

Comments

@adashrod
Copy link

Feature Request

First, thanks for building this app. Very nice REST API design, too.

I just finished writing a WebSocket client to connect to /v1/receive/{number} to have a bot respond to messages.
After I finished it I put it in a shell script and mistyped the phone number to pass into the WebSocket endpoint. The mistyped number is not registered with signal-cli-rest-api or even as a Signal account, but the WebSocket connection was established normally. I was very confused when I stopped getting messages delivered on the web socket.

I think it would be great if the server could refuse the connection if the number is invalid, or if that isn't possible, maybe send a ping message with an error description. That might save someone else some headache if they also type a phone number incorrectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant