Deprecate RequestStub#then

[Nakilon]

I believe it's useless

webmock/lib/webmock/request_stub.rb

Lines 94 to 96 in 63940ac

	def then
	self
	end

and it conflicts with the new Ruby method #then. I've just got caught on it here:

p( stub_request(mtd, url).then do |_|
  with_any_query ? _.with(query: hash_including({})) : _
end ).to_return ...

[Nakilon]

Workaround:

WebMock::RequestStub.remove_method :then

[bblimke]

@Nakilon thank you for reporting.

The inclusion of then was intended to enhance readability by providing syntactic sugar for stub declaration, as demonstrated in this example. However, I acknowledge that its presence in Object leads to confusion now.

To address this, I am considering the addition of and_then, accompanied by a deprecation notice for then, followed by the release of a new minor version 3.x. Subsequently, we can proceed with the removal of then in WebMock 4.0.x.

I would appreciate your thoughts on this approach.