Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPMethod enum causes conflicts with ESPAsyncWebServer #13

Open
sidoh opened this issue Dec 10, 2017 · 0 comments
Open

HTTPMethod enum causes conflicts with ESPAsyncWebServer #13

sidoh opened this issue Dec 10, 2017 · 0 comments

Comments

@sidoh
Copy link

sidoh commented Dec 10, 2017

Thank you very much for porting this to ESP32!

In one of my projects, I'm using ESPAsyncWebServer, which also defines a non-class enum for HTTP_GET, etc. I wanted to use WiFiManager as well, but since that pulls in WebServer, I was getting conflicts for these constants.

I re-defined these constants in WebServer_tng using enum class, which resolved the issue. Changes are here:

sidoh@75d2645

Happy to open a PR, but since this affects consumers (they'd need to reference these constants using the HTTPMethod:: namespace), I figured an issue would be more appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant