Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property of inputs and outputs should be a path #25

Open
forman opened this issue Nov 5, 2024 · 0 comments
Open

Property of inputs and outputs should be a path #25

forman opened this issue Nov 5, 2024 · 0 comments

Comments

@forman
Copy link
Member

forman commented Nov 5, 2024

The property name field of callback inputs and outputs should be normalized to a property path.

export interface InputOutput {
  kind: InputOutputKind;
  id?: string;
  property: string[];  // A path now!
}

Hence, when the UI receives a name from the server, it should be normalized using input = {...input, property: input.property.split(".")}.

After the change, we should only use property using get/set as provided by https://github.com/mariocasciaro/object-path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant