[MIGRATION][NMP#648] catchup on migrations #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
acatchpole
commented
Aug 12, 2024
| @@ -46,6 +46,7 @@ public Startup(IWebHostEnvironment env) | |||
|
|
|||
| if (env.IsDevelopment()) | |||
| { | |||
| builder.AddJsonFile("secrets.json", optional: true, reloadOnChange: true); | |||
There was a problem hiding this comment.
This is the only real change in this file and it is unrelated to migrations. Adding this line worked as a fix for a hard-to-address local development issue (only one dev had the issue) but it does not seem to have any side effects for working builds.
All other changes in this file are linting
There was a problem hiding this comment.
Yes I think this is OK as we want to unblock you. I would create a ticket and maybe leave a TODO in the code to pull this out when you offboard from NMP.
fergmac
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Standards
HOTFIX,FEATURE,etc][NMP-###]README,functions,team documents]Description
When a new migration is created, a model snapshot is used to find all the model changes that do not yet have migration-associated changes. The last migration for NMP was in 2020. A new migration has been created (CatchupModelUpdate) that catches all the model updates that should have already had migrations associated with them.
SNAGS:
In my testing of migrations, the dev db was put into a suboptimal state. the migration history is inaccurate and likely irreconcilable. Currently, it is not possible to run new migrations on the dev db (at least not with the auto-generated migration code). This db will need to be restored to a working state
The production database does not have a record of running the last migration, but the results of that migration are present (the 'Depths' table). This might cause errors when rebuilding prod as the migration will run and it will try to add a table that already exists.
This PR includes the following proposed change(s):
-ALSO INCLUDED: a fix for an issue only affecting one dev. This fix explicitly adds the secret.json to the Configuration object when in a dev env.